search

SAP-samples / ui5-cap-event-app

Showcase of SAP Cloud Application Programming Model and OData V4 with draft mode in a freestyle SAPUI5 app and an SAP Fiori elements app.
Apache License 2.0
90 stars 36 forks source link

Align UI5 version with ui5.yaml #15

Closed gregorwolf closed 1 year ago

gregorwolf commented 1 year ago

needs also to be applied in the js-with-typescript-support branch. Without this corrections both apps in the js-with-typescript-support branch show only a blank screen as the UI5 version 1.94.0 is outdated and has been removed from the CDN.

akudev commented 1 year ago

Hi Gregor, thanks a lot for the PR. However, there is apparently a lot of prettifying going on. Was this intentional?

akudev commented 1 year ago

Any intentional re-formatting should be discussed separately. And as the new long-term release 1.108 just got available on ui5.sap.com a few minutes ago, I'd prefer that one. So I created https://github.com/SAP-samples/ui5-cap-event-app/pull/17 instead.

Nevertheless thanks for pointing out the issue and creating the pull requests!

gregorwolf commented 1 year ago

Sorry @akudev I always have prettier on by default. Thank you for doing the adjustments in the other PR.