search

SAP-samples / ui5-typescript-walkthrough

A walkthrough tutorial that introduces all major development paradigms of OpenUI5 using TypeScript with OpenUI5.
https://sap-samples.github.io/ui5-typescript-walkthrough/
Apache License 2.0
26 stars 19 forks source link

docs: add Test Starter #65

Open maxreichmann opened 1 week ago

maxreichmann commented 1 week ago

Dev Guide explaining Test Starter: https://ui5.sap.com/#/topic/032be2cb2e1d4115af20862673bedcdb

JIRA: CPOUI5FOUNDATION-819

margopolo commented 1 week ago

What is the minimum OpenUI5 version required for the test starter? We currently require version 1.129. If a higher version is necessary, all steps in this tutorial will need to be updated to match the new version.

maxreichmann commented 1 week ago

Are there indeed no additional resources (e.g. chapters in the documentation) about the test starter?

In general, I believe there is still some explanation needed so beginners can understand and extrapolate from the tutorial to their use cases.

In addition, the link for previewing this step on the github page is not adapted also file test/unit/unitTests-cdn.qunit.html was deleted. I would assume that two additional files (testsuite-cdn.qunit.html and Test-cdn.qunit.hmtl) are still needed to compliment this step. Also, in the readme we would need a new image (or rather link) for the folder structure, as the current one does not fit anymore.

Regarding additional resources, these Dev Guide chapters could be helpful (and is linked in Step 27)

Regarding the link for previewing this step on the github page: I don't fully understand. How exactly does this preview work? The README.me file can at least be viewed as the compiled markdown code locally.

Regarding the deletion of the two cdn files. I assumed these two files are not necessary anymore with the introduction of the Test Starter.

A new image of the new folder structure is indeed necessary and will be added by UA colleagues.

codeworrior commented 1 day ago

@margopolo AFAIK, minimal version for using it in apps is 1.124.

matz3 commented 1 day ago

Now it's ready for review. We'll update the other steps once the content is approved to keep the changes for review as small as possible. Only steps 27 and 28 make changes in the test folder, so it can just be overwritten.