search

SAP-samples / ui5-webcomponents-ngx-sample

Sample application to demonstrate UI5 Web Components for Angular powered by Fundamental Library Styles.
https://ui5-webcomponents-ngx-sample.netlify.app/
Apache License 2.0
6 stars 2 forks source link

Mocks should be moved somewhere else #42

Closed g-cheishvili closed 1 year ago

g-cheishvili commented 1 year ago

Is this a bug, enhancement, or feature request?

Enhancement

Briefly describe your proposal.

Assets are things, that should not contain a code. If we want to have the data as an asset, then they should be in JSON format and downloaded using HttpClient. TS files, which are in assets should not be imported directly from application files. The fastest fix would be to use JSON and use HttpClient to get them in runtime

g-cheishvili commented 1 year ago

Also, the constant-queries file contains helpers and env variables. Those should be moved as well