search

SAP-samples / ui5-webcomponents-sample-angular

UI5 Web Components Sample TODO application built with Angular.
https://sap-samples.github.io/ui5-webcomponents-sample-angular/
Apache License 2.0
36 stars 13 forks source link

Failing to compile with default #33

Closed gman77 closed 2 years ago

gman77 commented 3 years ago

Following the instructions, however when building using npm start

ERROR in ./src/app/app.module.ts Module not found: Error: Can't resolve '@ui5/webcomponents-base/dist/features/browsersupport/Edge' in '/Users/Documents/sap/upscale/ui5-webcomponents-sample-angular/src/app' ℹ ｢wdm｣: Failed to compile.

Remarking out the following line in app.module.ts, allows compile: // import "@ui5/webcomponents-base/dist/features/browsersupport/Edge";

Maybe just update the documentation or have it commented out by default and those that use Microsoft Browsers can enable.

ilhan007 commented 2 years ago

Hello @gman77 the 'import "@ui5/webcomponents-base/dist/features/browsersupport/Edge";' is now removed the docs are updated