search

SAP / PyRFC

Asynchronous, non-blocking SAP NW RFC SDK bindings for Python
http://sap.github.io/PyRFC
Apache License 2.0
512 stars 140 forks source link

Is Pyrex really needed? #160

Closed amarvin closed 4 years ago

amarvin commented 4 years ago

Would be easier to maintain this repo if the codebase was Python files (*.py) and not Pyrex (*.pyx). As few people know Pyrex, it makes it harder for people to contribute.

I see that Pyrex is a Python-like language used for writing Python extension modules with C-like syntax; may contain references to existing C modules; compiles code that increases the execution time of Python programs. Is the reduction in execution time in this case significant?

mtolksdorf commented 4 years ago

A pure python implementation is not feasible as there are some libraries needed that require Pyrex in order to communicate with an ABAP system. Wrapping SAP NetWeaver RFC library is the way with the lowest effort and with the most code re-use.

bsrdjan commented 4 years ago

PyRFC is an interface to SAP NetWeaver SDK C++ library and Pyrex/Cython makes the Python/C++ integration work at all. Therefore inevitable for the time being although pure Python approach would simplify also cloud deployments. Execution time reduction is a nice "side-effect" of the approach.

amarvin commented 4 years ago

Thanks for the quick feedback!