search

SAP / SapMachine-infrastructure

Tools, scripts and infrastructure required to built, test and maintain the SapMachine project
Apache License 2.0
21 stars 14 forks source link

Add support to make_deb.py to work also for JRE instead of JDK #35

Closed chalstrick closed 1 year ago

chalstrick commented 1 year ago

@MBaesken : Both of your comments point to flaws in my initial request. I fixed it and pushed a new version

MBaesken commented 1 year ago

debian-templates/jre/control

Provides java-compiler makes probably no sense for jre , I think there is no compiler (javac) in JRE. Should we handle jre-11 too in the provides flags ?

debian-templates/jre/postinst

the update-alternatives --install /usr/bin/$$i $$i /usr/lib/jvm/sapmachine-${major}/bin/$$i path does not match any more the path in install file

RealCLanger commented 1 year ago

Maybe you want to modify make_deb.py right away, instead of adding a make_deb_ext.py?

chalstrick commented 1 year ago

spent some time to find out ... this commit is already in origin/master. So I will close this one