search

SAP / SapMachine

An OpenJDK release maintained and supported by SAP
https://sapmachine.io
GNU General Public License v2.0
509 stars 93 forks source link

Stale releases `sapmachine-17`, `sapmachine-21` #1641

Closed mpern closed 7 months ago

mpern commented 7 months ago

The github releases sapmachine-17 and sapmachine-21 point to now outdated patch releases.

This breaks downstream tooling like asdf-vm, mise and others because the use the GH release information to determine the available versions.

The easiest fix would be to get rid of all GH releases with a truncated versions (add .0.0 as minor and patch version) and make sure that the initial release is always XX.0.0

RealCLanger commented 7 months ago

Hi @mpern,

we can not delete the outdated releases from GitHub. We never do, since we can not know which automation relies on them. One could say it is unfortunate that the OpenJDK delivers the initial release of a major without .0* and then only adds it to update versions, but that's how it is and has been for quite a while now. If that's a problem for tooling, one should have a look at the tools, I guess.

Not sure whether the tools could also use our release information data, e.g. https://sap.github.io/SapMachine/assets/data/sapmachine-releases-latest.json

Or the "latest version" links like https://sap.github.io/SapMachine/latest/17 ?

mpern commented 7 months ago

HI @RealCLanger,

thanks for the reply! I wasn't aware that the versioning scheme is coming from OpenJDK, the more you know...

thanks for the links, this gives me some ideas for a PR for the downstream tooling. Looks like we need to sneak in a .0.0 somewhere...