search

SAP / SapMachine

An OpenJDK release maintained and supported by SAP
https://sapmachine.io
GNU General Public License v2.0
509 stars 93 forks source link

SapMachine #1670: Improve patch for jcmd GC.heap_dump modification #1698

Closed RealCLanger closed 4 months ago

RealCLanger commented 4 months ago

The SapMachine commit to modify the jcmd GC.heap_dump was taken directly from the OpenJDK proposal. In that form, however, it creates a too large upstream diff which could be reduced.

fixes #1670

SapMachine commented 4 months ago

Hello @RealCLanger, this pull request fulfills all formal requirements.

RealCLanger commented 4 months ago

I think we miss (now?) a couple of // Sapmachine comments (e.g. heapDumper.cpp).

Yes, it was my plan to add them after everything builds and tests are green 😄

The globals.hpp change was omitted now; this is okay with me if it is seen better this way (to keep diffs low).

No, it is already in the sapmachine code and won't be rolled back. The actual fix after these modifications can only be seen by diffing all files against openjdk.

SapMachine commented 4 months ago

Hello @RealCLanger, this pull request fulfills all formal requirements.

SapMachine commented 4 months ago

Hello @RealCLanger, this pull request fulfills all formal requirements.

SapMachine commented 4 months ago

Hello @RealCLanger, this pull request fulfills all formal requirements.