search

SAP / SapMachine

An OpenJDK release maintained and supported by SAP
https://sapmachine.io
GNU General Public License v2.0
504 stars 92 forks source link

Make test for unique stacks more robust #1811

Closed schmelter-sap closed 1 week ago

schmelter-sap commented 2 weeks ago

This changes the way the stack traces are routed to the test the uniques stacks test, since it produces a big output. We now let the profiled VM print the stacks to stderr and not use the output of jcmd, since the latter is buffered in the profiled VM first and there are hard limits on the maximum size of that buffer,.

fixes #1810

SapMachine commented 2 weeks ago

Hello @schmelter-sap, this pull request fulfills all formal requirements.

schmelter-sap commented 1 week ago

OK. We should port this fix to upstream, too, I guess?

If this really fixes the problem in the tests.

RealCLanger commented 1 week ago

OK. We should port this fix to upstream, too, I guess?

If this really fixes the problem in the tests.

It should - it looks greenish now. And the error happened on all our ppc64le nodes before.