SAP / SapMachine

An OpenJDK release maintained and supported by SAP
https://sapmachine.io
GNU General Public License v2.0
504 stars 92 forks source link

KSE with SAPMachine OpenJDK #929

Open blueicehaller opened 3 years ago

blueicehaller commented 3 years ago

Hi,

can you please implement that the SapMachine installer sets the following registry values?

Windows Registry Editor Version 5.00

[HKEY_LOCAL_MACHINE\SOFTWARE\WOW6432Node\JavaSoft]

[HKEY_LOCAL_MACHINE\SOFTWARE\WOW6432Node\JavaSoft\Java Runtime Environment]
"CurrentVersion"="11.0"

[HKEY_LOCAL_MACHINE\SOFTWARE\WOW6432Node\JavaSoft\Java Runtime Environment\11.0]
"JavaHome"="C:\\Program Files\\SapMachine\\JDK\\11"
"MicroVersion"="0"

Further Information: https://github.com/kaikramer/keystore-explorer/issues/292

Thank you in advance.

nice2mitja commented 3 years ago

Hey there,

thanks for reaching out! I will check your request and get back soon with further information!

MBaesken commented 2 years ago

Hi, are you aware of the registry entries we already have? https://github.com/SAP/SapMachine-infrastructure/blob/master/wix-templates/SapMachine.jdk.wxs.template#L51 Reusing the proposed JavaSoft entries is a bit controversial because we might clash with other peoples software, this is not really what we would like to see.

blueicehaller commented 2 years ago

Hi @MBaesken , I assume that either Oracle Java or SAPMachine is installed. Oracle Java is meanwhile not free for Corporate usage.

Before setting the registry entries I proposed the SAPMachine installer need to check if the value is not set or ask what to do.