SAP / abap-cleaner

ABAP cleaner applies 75+ cleanup rules to ABAP code at a single keystroke
Apache License 2.0
385 stars 42 forks source link

CORRESPONDING ... EXCEPT and LOOP AT ... GROUP BY indentation #330

Open vonglan opened 1 week ago

vonglan commented 1 week ago

Hi Jörg-Michael,

it seems these do not work as expected (or maybe something is wrong with my ADT/installation?):

      APPEND CORRESPONDING #( group->*
                      EXCEPT mode_response_time_secs
                        mode_response_time_percentage ) TO it_agg REFERENCE INTO DATA(wa_agg). 

and

    LOOP AT it REFERENCE INTO DATA(group)
         GROUP BY ( syst = group->syst
                        begin_date = group->date_in_system_tz
                    instance = group->instance
                        tcode = group->tcode
                    progname = group->progname
                    task_type = group->task_type
                      screen_nr = group->screen_nr
                    jobname = group->jobname ). 

In both cases, I would expect the field names to be aligned.

Best regards, Edo

jmgrassau commented 5 days ago

Hi Edo,

excellent, those cases are indeed not yet considered, thanks a lot!

Kind regards, Jörg-Michael

vonglan commented 6 hours ago

if you want to do that, here is another:

      SPLIT line->* AT ';' INTO wak-pgmid
                              wak-object
                                wak-objname
                                wak-mastertype.
vonglan commented 5 hours ago

and it seems there is another:

          APPEND CORRESPONDING #( key->*
                                  MAPPING obj_type = object
                                  obj_name = objname ) TO object-keys.