search

SAP / abap-file-formats-tools

Tools for the development of ABAP file formats
MIT License
25 stars 6 forks source link

AFF Generator Shall Generate `$multipleOf` Only for Fields of Type Integer #230

Closed burcuka closed 1 year ago

larshp commented 1 year ago

2500 lines change, suggest moving the indentation changes to a different PR

larshp commented 1 year ago

https://github.com/abaplint/transpiler/issues/963

larshp commented 1 year ago

https://github.com/open-abap/open-abap-core/pull/595

larshp commented 1 year ago

the unit test fails as the generated schemas doesnt match the formats repo, so we should probably move that part to a non-required step

larshp commented 1 year ago

"Lint for editorconfig violations" was renamed to "EditorConfig / Check indentation, EOL, EOF, ... (pull_request)" with https://github.com/SAP/abap-file-formats-tools/commit/f433ecee98378db9442730efa3ce071113657aa4 so the required status checks must be changed, https://docs.github.com/en/repositories/configuring-branches-and-merges-in-your-repository/defining-the-mergeability-of-pull-requests/managing-a-branch-protection-rule

I also recommend setting "Do not allow bypassing the above settings." so no-one can push to the protected main branch

schneidermic0 commented 1 year ago

I have updated the rules