search

SAP / abap-file-formats-tools

Tools for the development of ABAP file formats
MIT License
25 stars 6 forks source link

Fix no escaping for standard escapes in regular expressions #315

Closed jonassobotta closed 1 month ago

jonassobotta commented 1 month ago

fixes https://github.com/SAP/abap-file-formats-tools/issues/314

jonassobotta commented 1 month ago

@wurzka @Markus1812 The failing test runs successfully when I run it locally with ABAP Unit. Do you have any ideas why it might fail in the gh action?

larshp commented 1 month ago

add a skip to https://github.com/SAP/abap-file-formats-tools/blob/fix-regex-escape-sequences/test/abap_transpile.json#L55 to make the unit tests succeed, I spend some time yesterday to try fixing the regex, but too much escaping of stuff

jonassobotta commented 1 month ago

add a skip to https://github.com/SAP/abap-file-formats-tools/blob/fix-regex-escape-sequences/test/abap_transpile.json#L55 to make the unit tests succeed, I spend some time yesterday to try fixing the regex, but too much escaping of stuff

Thank you! @larshp

jonassobotta commented 1 month ago

Looks also good to me. But I agree with @Markus1812 about adding the test.

I added the test and also verified that it works with a single quote '