SAP / abap-file-formats-tools

Tools for the development of ABAP file formats
MIT License
25 stars 6 forks source link

Delete enum related logic #65

Open larshp opened 2 years ago

larshp commented 2 years ago

the abap-file-formats is in 702 syntax, so enums are out of scope?

suggest deleting the related logic in this repository, less code is easier to get running, plus ENUMS in ABAP is a mess...

larshp commented 2 years ago

looks like some is used for internal logic

  TYPES:
    BEGIN OF ENUM enum_formatting_option STRUCTURE formatting_option,
      no_formatting VALUE IS INITIAL,
      camel_case    VALUE 1,
    END OF ENUM enum_formatting_option STRUCTURE formatting_option,

    BEGIN OF ENUM enum_type_info STRUCTURE type_info,
      string,
      numeric,
      boolean,
      date_time,
    END OF ENUM enum_type_info STRUCTURE type_info,

    BEGIN OF ENUM enum_operation STRUCTURE operation,
      initial,
      write_element,
      open_structure,
      close_structure,
      open_table,
      close_table,
    END OF ENUM enum_operation STRUCTURE operation.

and some, is external facing logic which is not needed?

      get_enum_values
        IMPORTING element_name        TYPE string
                  element_description TYPE REF TO cl_abap_elemdescr
        RETURNING VALUE(result)       TYPE string_table
        RAISING
                  zcx_aff_tools,

      get_enum_descriptions
        IMPORTING element_name        TYPE string
                  element_description TYPE REF TO cl_abap_elemdescr
        RETURNING VALUE(result)       TYPE string_table,
larshp commented 2 years ago

was hoping not to downport ENUMs but guess I'll add that, work work 🚈

larshp commented 2 years ago

testcase, can be removed, out of scope?

  METHOD enum_element.
*  base type / base structure/ ohne (integer)
    TYPES:
      BEGIN OF ENUM category,
        general ##NEEDED,
        classic_badi ##NEEDED,
      END OF ENUM category.
albertmink commented 2 years ago

This is two fold (both to be removed!):

larshp commented 2 years ago

keep the internal logic as is, I implemented automatic downport of ENUMS to constants earlier today,

image

albertmink commented 2 years ago

So (hypothetically) I could do a downport on my local machine and copy/paste the results to the repository, right?

larshp commented 2 years ago

yea (but in this case we want to maintain the code in the high version/ENUM)