search

SAP / abap-file-formats-tools

Tools for the development of ABAP file formats
MIT License
25 stars 6 forks source link

Replace SOBJ_NAME with SYSUUID_C36 #67

Closed larshp closed 2 years ago

larshp commented 2 years ago

https://github.com/SAP/abap-file-formats-tools/blob/a3d6f9aec20cb1385f3d4b614c4779e0ec159158/src/zcl_aff_writer_json_schema.clas.testclasses.abap#L110

SYSUUID_C36 is released, https://abapedia.org/steampunk-2202-api/sysuuid_c36.dtel.html, and I think it fits with the test scenario?

plus it exists in https://github.com/open-abap/open-abap/blob/main/src/uuid/sysuuid_c36.dtel.xml

larshp commented 2 years ago

I cannot run the code, so I cannot do this refactoring, as the unit test will probably break if its not tested

larshp commented 2 years ago

okay, well, I'll give it a go then