search

SAP / abap-file-formats

File formats that define and specify the file representation for ABAP development objects
MIT License
58 stars 55 forks source link

Object types do not support ABAP language version `keyUser` #320

Closed schneidermic0 closed 2 years ago

schneidermic0 commented 2 years ago

Following object types actually do not support ABAP language version keyUser, but specify this in their enum values:

larshp commented 2 years ago

again, I'd argue to remove the language version from the object definitions, what if NROB sometime is supported in keyUser? Then the object definition must be changed, but its just another runtime that supports the object

schneidermic0 commented 2 years ago

I don't think we can remove the ABAP language version as it is stored per object. This design, IMHO, cannot be changed by ABAP file formats. See #44

If new enum values appear in the future, it will be added. We have the same issue for all other enumerations. Currently, we consider this as compatible change.

See: https://github.com/SAP/abap-file-formats/blob/main/docs/json.md#format-versions-and-compatibility

Values for a field (enum) are added (remark: this might lead to syntax errors in ABAP systems which don't support this value)

larshp commented 2 years ago

the file format does not need to directly reflect the implementation in the system, eg. specific names and/or fields

🎪

schneidermic0 commented 2 years ago

the file format does not need to directly reflect the implementation in the system, eg. specific names and/or fields

Sorry, I don't understand what you mean

larshp commented 2 years ago

just going in circles 😁 https://github.com/SAP/abap-file-formats/issues/44

schneidermic0 commented 2 years ago

Also fixed with https://launchpad.support.sap.com/#/notes/3138884

This Note has been already linked in https://github.com/abapGit/abapGit/issues/5279