SAP / abap-file-formats

File formats that define and specify the file representation for ABAP development objects
MIT License
58 stars 56 forks source link

Field `high` in a ranges marked as `required` #322

Closed schneidermic0 closed 2 years ago

schneidermic0 commented 2 years ago

Field high in a range for CHKV is specified as required:

https://github.com/SAP/abap-file-formats/blob/6994c9a9a4b648fd3349577f0e1330186f5f46b7/file-formats/chkv/type/zif_aff_chkv_v1.intf.abap#L22

schneidermic0 commented 2 years ago

Short addition: Most probably, field low is also not required because it accepts initial values.

However, I think it make sense to mark field low at least as $showAlways so that it is rendered even with initial values during serialization.

schneidermic0 commented 2 years ago

In general, the idea came up whether we should support TYPE RANGE OF in the AFF type interface to define ranges (instead of creating range structures and corresponding tables manually)

schneidermic0 commented 2 years ago

In general, the idea came up whether we should support TYPE RANGE OF in the AFF type interface to define ranges (instead of creating range structures and corresponding tables manually)

Created a new issue in abap-file-format-tools to support this. See SAP/abap-file-formats-tools#76

schneidermic0 commented 2 years ago

Also fixed with https://launchpad.support.sap.com/#/notes/3138884

This Note has been already linked in https://github.com/abapGit/abapGit/issues/5279