search

SAP / abap-file-formats

File formats that define and specify the file representation for ABAP development objects
MIT License
58 stars 56 forks source link

Invalid abapdoc? #404

Open larshp opened 2 years ago

larshp commented 2 years ago

Hi, When activating abapGit standalone, the editor gives the following warnings regarding the abapdoc,

ref https://help.sap.com/doc/abapdocu_752_index_htm/7.52/en-us/abendoccomment.htm

750 SP0022 and 750 SP0006

seems okay on 754 SP0002

https://help.sap.com/doc/abapdocu_754_index_htm/7.54/en-US/abennews-752-abap_doc.htm

guess there is a SAP note to downport the logic to 750 and 702?

image

larshp commented 2 years ago

Actions:

  1. strip abapdoc comments in https://github.com/abapGit/aff_mirror, perhaps replace with a reference to this repository
  2. consider if its worth changing https://github.com/SAP/abap-file-formats/blob/main/abaplint.jsonc#L13
  3. @schneidermic0 to check for SAP Notes
albertmink commented 2 years ago

Maybe I can take oder the deletion of AbapDoc in the mirror repository. Some 'sed' magic should do it

larshp commented 2 years ago

@albertmink yea, cool, sed solves many things 😄 if it solves too much, then abaplint will complain

albertmink commented 2 years ago

Action 1 is implemented, see https://github.com/abapGit/aff_mirror/pull/53

schneidermic0 commented 2 years ago

@schneidermic0 to check for SAP Notes

I will check whether there is a SAP Note.