search

SAP / abap-file-formats

File formats that define and specify the file representation for ABAP development objects
MIT License
58 stars 55 forks source link

DOMA feedback #533

Open larshp opened 1 year ago

larshp commented 1 year ago

https://github.com/SAP/abap-file-formats/blob/main/file-formats/doma/type/zif_aff_doma_v1.intf.abap

TYPES ty_data_type TYPE c LENGTH 4. this is the internal data type(after conversion exit), ie. not what developers see in SE11?

there is also fixed value appends, which as far as I remember are related to domains?

schneidermic0 commented 1 year ago

The data type represents the predefined type of the domain.

This is the first value the user has to enter in the editor (see screen shot of ADT and SE11):

image image
schneidermic0 commented 1 year ago

I guess you are right. The aspect of value appends seems not to be covered, yet

larshp commented 1 year ago

yea, so as a developer I enter "DF16_DEC", what goes into the field of length 4,

TYPES ty_data_type TYPE c LENGTH 4.

? image

schneidermic0 commented 1 year ago

OK. Now, I get your point. Yes, I agree. The length of 4 characters does not make sense in the file format. Even if the actual field value on DB is only 4 characters, the ABAP file format should use either (a) values used by the enduser in the tools (ADT/SE11) or have (b) proper enum values. I think I would prefer option a (these can be still also the enum/constant values)