search

SAP / abap-file-formats

File formats that define and specify the file representation for ABAP development objects
MIT License
58 stars 55 forks source link

[EDCK] Add new object type for EDCK #629

Open KUMARMUKULSAP opened 3 months ago

cla-assistant[bot] commented 3 months ago

CLA assistant check
All committers have signed the CLA.

cla-assistant[bot] commented 3 months ago

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

GuilhermeSaraiva96 commented 2 months ago

Furthermore, the example object is missing

KUMARMUKULSAP commented 4 weeks ago

@Markus1812 : I have incorporated all above review comments. However, I am stuck at the check Generated Json Schema differs from provided ones. I am not really sure how to resolve this error. I cannot find out from where I can download the generated JSON schema to perform the comparison with the provided JSON schema. Please help.

KUMARMUKULSAP commented 4 weeks ago

@Markus1812 : Thank you for helping out. I have incorporated the review comments. and deleted the .DS_Store file as well. Please approve.

Markus1812 commented 3 weeks ago

In case you have missed it: One comment above is still unresolved. There was not only the z missing of zif... missing but also the exist has to be existence_check to be the same as the constant name.

https://github.com/SAP/abap-file-formats/pull/629#discussion_r1745227671

KUMARMUKULSAP commented 3 weeks ago

@Markus1812 : Constant name of the default value has been corrected as well. Let me know if further changes are required.

KUMARMUKULSAP commented 1 week ago

@wurzka : Requested changes are done.