Open raghav6686 opened 3 weeks ago
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.
We have spoken within the team, could you please setup a meeting with me (Guilherme Saraiva), Nicolas Huber and Michael Schneider? We do not usually ask for meeting, but due to the urgency of the delivery and the complexity of the AFF, we think it is best.
I have added several comments now. In a first step, I would focus on structural changes of the AFF like:
bindings
andbinding_mappings
orsignature*
,modeling*
andparameter*
.Furthermore, an example would be nice to see the references of
INTM
toINTS
.I expect more feedback after this iteration.
I've done the changes. Please review and let me know in case of any comments.
Sentence case means that only the first letter of the first word is capitalised. Sorry that you changed all of the descriptions, they need to be reverted
I've done then changes.
I had a look at recent changes. But I haven't managed to look into all details, yet. This object has a huge list of fields.
@huber-nicolas gave some input on differences between the title (shorttext description) and the field name. If possible we should keep them in sync. However, whether you change the field name or the title is up to you. I guess, there we see anyhow further suggestions during UX review. But I would keep them in sync already.
All committers have signed the CLA.