SAP / apibusinesshub-integration-recipes

Accelerate integration projects using SAP Cloud Platform Integration with crowdsourced best practices, curated by experts, designed for developers.
Apache License 2.0
110 stars 84 forks source link

Issue with "GoLiveDate" external parameter for SAP SuccessFactors Employee Central with Third-Party Payroll Vendor #92

Closed sgkulkarni closed 7 months ago

sgkulkarni commented 1 year ago

Describe the bug The configuration parameter "GoLiveDate" is not taken into account in the "payrollProcessingLogic.gsh". The Script is looking for the "ADPGoLiveDate" (old?) parameter. This results in the iFlow in deployment error as below- Error Details javax.script.ScriptException: java.lang.Exception: java.lang.NullPointerException: while trying to invoke the method java.lang.String.length() of a null object loaded from local variable 'text'@ line 16 in payrollProcessingLogic.gsh, cause: java.lang.NullPointerException: while trying to invoke the method java.lang.String.length() of a null object loaded from local variable 'text'

To Reproduce Steps to reproduce the behavior:

  1. Go to 'SAP SuccessFactors Employee Central with Third-Party Payroll Vendor'
  2. Click on 'Configure the iFlow with parameters for SuccessFactors and SFTP details'
  3. Deploy the iFlow
  4. See error

Expected behavior With all required configurable parameters provided, there should not be any deployment error.

Screenshots image

image

Desktop (please complete the following information):

Additional context This just might be the reference to old ADP based variables, as this package is now generalized for any payroll providers.

sgkulkarni commented 7 months ago

This issue is fixed now in the latest update - version 1.0.1 1.0.1 03/11/2023 - Groovy Script payrollProcessingLogic.gsh changed for GoLiveDate