SAP / cf-html5-apps-repo-cli-plugin

Cloud Foundry CLI plugin to work with SAP Cloud HTML5 Applications Repository
Apache License 2.0
43 stars 6 forks source link

Pushing of themelibs to repo #37

Closed hschaefer123 closed 4 years ago

hschaefer123 commented 4 years ago

Description

I want to deploy a custom OpenUI5 themelib to the repo and get the warning:

WARNING: Directory 'themelib' is not an application and will not be pushed!

In general, my OpenUI5 themelib is working inside repo deployed by html5-app-deployer.

It would be great, if the plugin would also support this, because it makes it more comfortable to quickly release changes to dev systems.

Regards Holger

micellius commented 4 years ago

@hschaefer123 , thanks for reporting an issue! The HTML5 plugin require xs-app.json and manifest.json files to be on the root level of an application. In addition, you should have sap.app/id and sap.app/applicaitonVersion/version in manifest.json. If these conditions are met, you can push an application.

UI5 applications usually have dist folder generated during UI5 build. Deployer application deploys content of this dist folder. So, you can change your working directory to dist folder of themelib and cf html5-push. If UI application was previously deployed, you should add -r flag for redeploy (cf html5-push -r).

Can you please share the structure of your OpenUI5 themelib. Screenshot of file tree with expanded folders will be enough.

hschaefer123 commented 4 years ago

Hi, sorry, it was my fault.

The error message was irritating me. The problem is/was, that ui5 cli generate an additional /resource folder behind the target folder that is not done for apps. I did not recognize this, because VC always collapses empty folders and everthing looked like the app.

I still have thue issue from ticket 28, so that i have to use

cd deployer/resources/themelib/resources && cf html5-push -n webshop_html5_repo_host

from inside the folder to get rid of the wrong folder structure inside repo.

Also need to find a way getting rid of trailing /resources for deployer.js.

So i will close the ticket.

Regards Holger