search

SAP / cf-java-logging-support

The Java Logging Support for Cloud Foundry supports the creation of structured log messages and the collection of request metrics
Apache License 2.0
76 stars 46 forks source link

Fix logback stacktrace information #146

Closed KarstenSchnitter closed 2 years ago

KarstenSchnitter commented 2 years ago

This fixes issue #145:

Since v3.6.0 the stacktrace feature was not working properly in the logback implementation. Amongst the missing information was the exception class, the exception message and suppressed or caused exceptions. The proposed change brings back the original coding used before v3.6.0, which is also used in the log4j2 implementation.

Signed-off-by: Karsten Schnitter k.schnitter@sap.com

juergen-walter commented 2 years ago

I like the improvement of the test

juergen-walter commented 2 years ago

The proposed change brings back the original coding used before v3.6.0, which is also used in the log4j2 implementation.

Fix is a move forward and not a revert, what I initially assumed based on the comment. Therefore it took longer for me to understand.

calle2010 commented 2 years ago

It would be great if this were included in the next update of SAP Java Buildpack (1.53.0) on BTP on May 5. The currently announced change is to 3.6.1 only.

KarstenSchnitter commented 2 years ago

I cannot really comment on the progress on the SAP Java Buildpack. I know, that an internal process has started to provide the fix with a buildpack hotfix.

calle2010 commented 2 years ago

According to What's New information this has been integrated into SAP Java Buildpack 1.53.2 and 1.52.2