Use static loggers (or on-demand creation by holder)

SAP / cf-java-logging-support

The Java Logging Support for Cloud Foundry supports the creation of structured log messages and the collection of request metrics

Apache License 2.0

77 stars 48 forks source link

Use static loggers (or on-demand creation by holder) #83

Closed j-denner closed 4 years ago

j-denner commented 4 years ago

Switch to static loggers or on-demand creation by holder pattern. Rationale: When (for example) log4j is used, with each logger creation, a stack trace is captured. This is putting a measurable pressure on applications (Memory, CPU). The VM optimizes away the holder after first (implicitly) synchronized access.

CLAassistant commented 4 years ago

All committers have signed the CLA.

j-denner commented 4 years ago

In all other cases the logger is only created if an exception occurs. The issue is less pressing there, right?

Well, if this issue is isolated then I completely agree. But if there is a phase with continuous problems then it puts additional pressure on the system.

j-denner commented 4 years ago

@KarstenSchnitter: After switching to a static logger in LogContext, the unit tests fail for cf-java-logging-support-core. It seems that the static variant does not fit to the setup for the test. Shall I reenable the LoggerHolder in this class again?

KarstenSchnitter commented 4 years ago

We will create a new release in December. It will contain this PR.