SAP / cf-nodejs-logging-support

Node.js Logging Support for Cloud Foundry provides the creation of structured log messages and the collection of request metrics
https://sap.github.io/cf-nodejs-logging-support/
Apache License 2.0
43 stars 22 forks source link

Improve TypeScript compatibility #178

Closed christiand93 closed 1 year ago

christiand93 commented 1 year ago

Note: Base branch is "main". This will be the new default branch when we release v7.

alumni commented 1 year ago

It's great to see that you are embracing TypeScript, most of the SAP libraries that we use have quality issues that could have easily been prevented if only the code was properly typed and linted.

By the way, most of the changes in this PR could be fixed automatically with eslint + typescript-eslint - even the naming conventions! You should check it out for this project!