search

SAP / cf-nodejs-logging-support

Node.js Logging Support for Cloud Foundry provides the creation of structured log messages and the collection of request metrics
https://sap.github.io/cf-nodejs-logging-support/
Apache License 2.0
43 stars 22 forks source link

Typescript typings #65

Closed submetu closed 12 months ago

submetu commented 4 years ago

Hi can we get typings for `

That would be great, thanks!

nicklas-dohrn commented 3 years ago

So far, our whole library is written using javascript functionality, with no typescript specific coding. I see the benefit for having these typings, as it would really help to clarify which typings can be used.

At the moment, I am quite reluctant to add more dependencies to our library, as we have had only minimal issues with our minimal dependency approach. At the moment, the typings are created programmatically and are also able to change on runtime, that may prove hard to do with typings for typescript, but as I am not an expert on typescript, I may be proven wrong on this.

Sorry for my late answer, Nicklas

nazarkulyk commented 2 years ago

Actually typings would be really welcome as we write our backends in typescript too. Option is to use cloud-sdk/util logger to log out to kibana ob BTP.

Simple adding index.d.ts would do trick, we also can provide simple pool request with it...

christiand93 commented 12 months ago

As of version 7 TypeScript is supported and typings are available.