SAP / cloud-authorization-buildpack

You can use the content of this repository to leverage the Open Policy Agent (https://www.openpolicyagent.org/) for cloud foundry environments. If offers runtime support to make calls to the open policy server from a CF application and support to manage and distribute Open Policy Agent bundles.
Apache License 2.0
5 stars 6 forks source link

credential_type vs credential-type #38

Closed arapoport closed 2 years ago

arapoport commented 2 years ago

Buildpack prints a warning that has a typo in the advice:

**WARNING** identity service binding does not contain client certificate. Please use binding parameter {"credential_type":"X509_GENERATED"}

It should be {"credential-type":"X509_GENERATED"} (with an - instead of _).

See here:

https://github.com/SAP/cloud-authorization-buildpack/blob/5734f5694b51c66e46d2cec0cc506ebd679d7245/pkg/supply/services.go#L97

jkbschmid commented 2 years ago

Hi @arapoport , thanks for opening this ticket. Fixed with e04bfb66341ee9d44abb857aef89d31cdecf5f1c