MBT installation checking from node12 to node 20

SAP / cloud-mta-build-tool

Multi-Target Application (MTA) build tool for Cloud Applications https://sap.github.io/cloud-mta-build-tool

Apache License 2.0

139 stars 61 forks source link

MBT installation checking from node12 to node 20 #1073

Closed yutaoj closed 12 months ago

yutaoj commented 1 year ago

Before submitting a pull request, please ensure the following:

Description

Please explain the changes you made.

Add a link to the design (if applicable).

Checklist

[ ] Code compiles correctly
[ ] Relevant tests were added (unit / contract / integration)
[ ] Relevant logs were added
[ ] Formatting and linting run locally successfully
[ ] All tests pass
[ ] UA review
[ ] Design is documented
[ ] Extended the README / documentation, if necessary
[ ] Open source is approved

cla-assistant[bot] commented 1 year ago

Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.
1 out of 2 committers have signed the CLA.

:white_check_mark: yutaoj
:x: JiangYuTao
_{You have signed the CLA already but the status is still pending? Let us recheck it.}

jerome-benoit commented 12 months ago

What is the rationale for letting in node.js runtime version support that are EOLed?

known security issues are introduced in the SAP software supply chain that will never be fixed
compliance with SAP security policies needs exception request(s)

Has both points been considered with the SAP security officier attached to that project?