SAP / cloud-mta-build-tool

Multi-Target Application (MTA) build tool for Cloud Applications https://sap.github.io/cloud-mta-build-tool
Apache License 2.0
141 stars 61 forks source link

Using npm ci with the build tool #530

Closed RaynDol closed 5 years ago

RaynDol commented 5 years ago

Do you want to request a feature or report a bug?

Please provide the following info:

Steps to Reproduce:

We are working with the new tool for a few weeks, and it's a big step forward, we notice performance improvement for our builds by 30-40% which is very surprising, this is great! The make integration is great as we are able to extend with our new commands, e.g., we change the npm install production to npm ci which also give a boost to our builds, my question is if there is a way that we all benefit from it, I mean other teams will inherit our changes ? otherwise we will use a lot of boilerplate that we want to avoid.

Thank you

ShimiT commented 5 years ago

Hi,

Thanks for your feedback 👍 . One of our goal with the new MBT design was a clear separation of the build commands from the tool and use it from "external" config files; hence you can use the existing configs or contribute new one that fits your requirements and everybody can leverage, please have a look at the following references.

https://github.com/SAP/cloud-mta-build-tool/blob/master/configs/builder_type_cfg.yaml#L63 https://github.com/SAP/cloud-mta-build-tool/blob/master/configs/module_type_cfg.yaml

let me know if it answers your question.

RaynDol commented 5 years ago

HI,

We have tested it and this is really neat as it help us to reduce our boilerplate and improve our build performance 💯

Thanks!

katunin-ng commented 5 years ago

Hi,

Thank you for sharing your feedback. As far as I understood, this issue can be closed now.

Regards Natalia