DestinationNotFoundException generated when destination is found in CF

[rvez7]

Issue Description

The exception com.sap.cloud.sdk.cloudplatform.connectivity.exception.DestinationNotFoundException with text Could not find environment variable for name 'destinations'. is being raise when destination is found via CF service.

Important information:

• Your code final Try<Destination> tryDestination = DestinationAccessor.tryGetDestination(destinationName);
• Expected outcome : No DestinationNotFoundException instances shall be allocated.
• Actual outcome : I would except that EnvVarDestinationLoader.class would not loaded at all if the environment variable is missing.
• Steps attempted to resolve the issue : No convenient way to remove EnvVarDestinationLoader.class from the loading chain was found.
• Potentially missing information (open questions you might have)

Impact / Priority

The outcome is Dynatrace reporting this Exception as top occurrences creating noise to investigate more relevant Exceptions. Slowing down troubleshooting of issues in production by falsely reporting destination errors. Due to long calling stack, generating this exception unnecessarily is expensive memory wise.

Affected development phase: Production

Impact: e.g. Inconvenience

Timeline: Live.

Error Message

Could not find environment variable for name 'destinations'.
com.sap.cloud.sdk.cloudplatform.connectivity.exception.DestinationNotFoundException

EnvVarDestinationLoader.getJsonNodesJava \| com.sap.cloud.sdk.cloudplatform.connectivity
EnvVarDestinationLoader.extractDestinationJava \| com.sap.cloud.sdk.cloudplatform.connectivity
EnvVarDestinationLoader$$Lambda$.applyJava \| com.sap.cloud.sdk.cloudplatform.connectivity
EnvVarDestinationLoader.lambda$Java \| com.sap.cloud.sdk.cloudplatform.connectivity
EnvVarDestinationLoader$$Lambda$.applyJava \| com.sap.cloud.sdk.cloudplatform.connectivity
Try.ofJava \| io.vavr.control
EnvVarDestinationLoader.tryGetDestinationJava \| com.sap.cloud.sdk.cloudplatform.connectivity
DestinationLoaderChain.tryGetDestinationJava \| com.sap.cloud.sdk.cloudplatform.connectivity 
DestinationLoader.tryGetDestinationJava \| com.sap.cloud.sdk.cloudplatform.connectivity

Project Details

• SDK Version: 5.9.0 <groupId>com.sap.cloud.sdk</groupId> <artifactId>sdk-core</artifactId>
• Link to GitHub repo:
• Project type, for example:
  • [ ] CAP Project
  • [x] SDK Maven Archetype
  • [x] None of the above:
• Platform:
  • [x] Cloud Foundry
  • [ ] Deploy with Confidence (Cloud Foundry)
  • [ ] None of the above:

---

Checklist

• [x] Checked out the documentation and Stack Overflow
• [x] Description provided with all relevant information
• [x] Exception and stack trace provided
• [ ] Attached debug logs
• [ ] Attached dependency tree
• [x] Provided Cloud SDK version & link to relevant source code

[MatKuhr]

Hi @rvez7, you are right, this can be annoying when using tools like Dynatrace that monitor all thrown exceptions. Unfortunately, there is a tradeoff here between a few aspects like usability, error handling, convenience, modularity etc., which lead to the current approach.

You can avoid these exceptions by directly using new DestinationService(), which is the relevant implementation for loading destinations from the BTP Destination Service. However, then you'd have to implement a fallback to env vars manually, in case you are using that e.g. for local testing.