search

SAP / cloud-sdk-js

Use the SAP Cloud SDK for JavaScript / TypeScript to reduce development effort when building applications on SAP Business Technology Platform that communicate with SAP solutions and services such as SAP S/4HANA Cloud, SAP SuccessFactors, and many others.
Apache License 2.0
162 stars 56 forks source link

TypeScript invalid with TS compilerOptions "noImplicitOverride": true #4576

Open GoWale opened 6 months ago

GoWale commented 6 months ago

Describe the bug Generated TypeScript files are not valid when setting "noImplicitOverride": true in tsconfig.json

To Reproduce Steps to reproduce the behavior: git clone https://github.com/GoWale/issue-cloud_sdk-odatav4.git npm i

  1. Set up ... start the cap server via npm run start
  2. Execute ... npm run sdk_gen_client (with the running server providing the EDMX)
  3. See error now you should see the typescript complains in the console

Expected behavior generated typescript should support "noImplicitOverride"

Used Versions:

Impact / Priority

low / medium: we can add the override by hand or remove the typescript validation

Affected development phase: Development / CI/CD

deekshas8 commented 6 months ago

Hi @GoWale, This config setting is currently not supported. I'll create a ticket to update our client generators.

jjtang1985 commented 3 months ago

Hi @deekshas8, it seems we solved this issue with this PR #4687. Could you please confirm?