SAP / cloud-sdk-js

Use the SAP Cloud SDK for JavaScript / TypeScript to reduce development effort when building applications on SAP Business Technology Platform that communicate with SAP solutions and services such as SAP S/4HANA Cloud, SAP SuccessFactors, and many others.
Apache License 2.0
161 stars 51 forks source link

chore: update service credentials typing #4791

Closed marikaner closed 1 week ago

marikaner commented 1 week ago

xssec now comes with typings. Once they have fixed some bugs in the first version this is an issue that will still come up:

  1. ServiceCredentials have a required property url.
  2. We need to pass XsuaaServiceCredentials to the constructor of XsuaaService.

I checked - in this state we should be compatible, so the next dependabot PR with the fixes should automatically pass.