feat: improve support for IAS tokens

SAP / cloud-sdk-js

Use the SAP Cloud SDK for JavaScript / TypeScript to reduce development effort when building applications on SAP Business Technology Platform that communicate with SAP solutions and services such as SAP S/4HANA Cloud, SAP SuccessFactors, and many others.

Apache License 2.0

161 stars 51 forks source link

feat: improve support for IAS tokens #4799

Open marikaner opened 1 week ago

marikaner commented 1 week ago

This includes generalized handling of tokens so that XSUAA, IAS and other custom tokens.

I fixed some places to make sure the difference between subdomain (aka. tenant, aka. tenant name) and tenant ID (aka. zone ID, aka. app_tid) is hopefully more obvious and in some cases more correct. Especially the subdomain needs to be handled differently between XSUAA and IAS.

Closes SAP/cloud-sdk-backlog#1219. Closes SAP/cloud-sdk-backlog#1217.

marikaner commented 1 week ago

Please take my comments with a grain of salt, since the code is so complicated and I don't understand much if any of it. Comments are only based on the diff, not much else 😅

No worries! Thanks for the review! 😊