search

SAP / cloud-security-services-integration-library

Integration libraries and samples for authenticating users and clients bound to XSUAA authentication and authorization service or Identity authentication service.
Apache License 2.0
151 stars 136 forks source link

Revisit JWKS Cache logic #1241

Closed liga-oz closed 7 months ago

liga-oz commented 1 year ago

Potential suggestion: keySet == null || !keySet.containsAppTid(appTid) **_|| keySet.getAll().isEmpty()_** This will refresh empty JWKS instead of logging the error in line 175 for the whole cache duration and returning null. It means more load on XSUAA though when it returns empty JWKS.

_Originally posted by @finkmanAtSap in https://github.com/SAP/cloud-security-services-integration-library/pull/1238#discussion_r1270350843_

https://github.com/SAP/cloud-security-services-integration-library/pull/1237/files#r1269076951

finkmanAtSap commented 7 months ago

Closing this as Github Issue section is no longer maintained.