search

SAP / cloud-security-services-integration-library

Integration libraries and samples for authenticating users and clients bound to XSUAA authentication and authorization service or Identity authentication service.
Apache License 2.0
151 stars 136 forks source link

Incorrect scope for javax.servlet-api dependency in java-api #427

Closed vtintillier closed 3 years ago

vtintillier commented 3 years ago

javax.servlet-api dependency should always use provided scope, as those classes are provided by the Servlet container like Tomcat.

In java-api we have a compile scope dependency: https://github.com/SAP/cloud-security-xsuaa-integration/blob/d7faf413da7628eb91c6c60ba392f9b33c0eb90d/java-api/pom.xml#L29

nenaraab commented 3 years ago

Hi @vtintillier

oh yes, that's probably a good idea. We set it for spring-xsuaa as provided and SAP Java Buidlpack provides it as well.

Best regards, Nena

nenaraab commented 3 years ago

Hey @liga-oz

please check all dependencies to javax.servlet-api, whether it can be set to provided or test.

Thanks, Nena

vtintillier commented 3 years ago

Hi @nenaraab @liga-oz

not sure if you saw there is already a PR fixing the problem 😉

Thanks

nenaraab commented 3 years ago

Yeah, but I though, it can be removed from the samples as well?

nenaraab commented 3 years ago

Hi @vtintillier Thanks a lot for reporting AND contributing the fix! Enjoy your weekend!

vtintillier commented 3 years ago

Thanks @nenaraab . Do you want me to look at samples too?

nenaraab commented 3 years ago

Hi @vtintillier no, this is not needed. Thanks a lot for offering!!! We will check whether the dependency can be removed in the samples and perform our integration tests to check it. For that, I just like to keep this issue open.

liga-oz commented 3 years ago

Hi @nenaraab,

checked and verified with IT for scope change of servlet-api to provided. PR #444

BR, Liga