search

SAP / code-pal-for-abap

code pal for ABAP is a highly configurable engine, fully integrated into the ABAP development framework ensuring Cloud’s built-in quality.
Apache License 2.0
348 stars 66 forks source link

Redundancy of check classes #144

Closed ThomasErgin closed 4 years ago

ThomasErgin commented 4 years ago

I noticed, that several Code Pal checks are already covered from SAP standard checks. E.g. the Code Pal checks "Number of attributes", "Number of methods", "Number of public Attributes" is already integrated in the SAP standard check class "OO Size metrices". The Code Pal check "Nesting depth" is included in the SAP standard check "Program complexity Test" and so on. What is the reason for that? Users of Code Pal and SAP standard checks have to consider, which one of the checks is the better or more accurate one. If both checks are activated at the same time, they might produce redundant or even contradictory messages and the repository of the system (superfluously) increased. My recommendation would be, to remove any check classes from the Code Pal, that is already covered from the SAP standard.

lucasborin commented 4 years ago

Hi @ThomasKempfle,

Unfortunately, the code pal for ABAP is not a standard tool provided by SAP. This is an open-source project.

The reason why it has some "duplicated" checks is that in code pal for ABAP:

  1. You can filter by object creation date;
  2. You can choose between productive and test code;
  3. It excludes most of the generated code automatically;
  4. You can use the profile tool to customize the checks and export/import the configuration between systems.
  5. etc.

Besides, it is up to the user to decide if he/she wants to use the code pal for ABAP checks or the SAP standard ones.

Regards, Lucas & Eugen

estevao-schultz-neto-SAP commented 4 years ago

Besides, code pal was newly developed with A better (not to say state-of-the-art) OO Programming. What is not the case regarding these old checks you have mentioned.

ThomasErgin commented 4 years ago

Thank you for this information. Can anybody tell me, if the Code Pal checks will somehow become reflected to the SAP standard?

lucasborin commented 4 years ago

Code pal for ABAP started in SAP (internally) by some developers to support internal team needs, and we figured out that would be helpful for people out of SAP. Therefore, we converted it into an open-source project, so everyone can use, improve, and support it. Currently, this is not an official SAP tool or replacement for code inspector tool.

estevao-schultz-neto-SAP commented 4 years ago

Enhancing, code pal for ABAP is a initially developed by SAP and placed in the SAP Open Source Developer Hub. Although no official SAP Support (e.g.: translation) is offered for the tool, we are coordinating it and further developing it together with the OS Community.