search

SAP / credential-digger

A Github scanning tool that identifies hardcoded credentials while filtering the false positive data through machine learning models :lock:
Apache License 2.0
317 stars 49 forks source link

Include Branch name in the scan report export #324

Closed ManishYadav-SAP closed 3 weeks ago

ManishYadav-SAP commented 1 month ago

Suggestion: It would be good to include Branch name as well in the scan report export which can help developer to identifies the issue in some large repo which have multiple findings.

wassafshahzad commented 1 month ago

Can i pick this up ?

SlimTrabelsi commented 1 month ago

Hi @wassafshahzad Yes please 👍

wassafshahzad commented 3 weeks ago

Done

marcorosa commented 3 weeks ago

After thorough consideration, we have determined that implementing this feature is not feasible at this time. The primary reasons are the complexity and potential ambiguity involved in correctly attributing branch names to commits, as discussed in detail in #327 Given these challenges, we believe that the drawbacks outweigh the potential benefits. As such, we will be closing this issue. We are always open to new ideas and suggestions. If a viable solution or alternative approach arises in the future, we would welcome the opportunity to revisit this topic. In the meantime, please feel free to share any other feedback or proposals you might have.

wassafshahzad commented 3 weeks ago

After thorough consideration, we have determined that implementing this feature is not feasible at this time. The primary reasons are the complexity and potential ambiguity involved in correctly attributing branch names to commits, as discussed in detail in #327 Given these challenges, we believe that the drawbacks outweigh the potential benefits. As such, we will be closing this issue. We are always open to new ideas and suggestions. If a viable solution or alternative approach arises in the future, we would welcome the opportunity to revisit this topic. In the meantime, please feel free to share any other feedback or proposals you might have.

Is it ok for me to pick another issue ?

marcorosa commented 3 weeks ago

Yes, of course