Can we remove this `sed`?

SAP / devops-docker-node-browsers

Dockerfile for an image with node and web browsers. This image is intended to be used for end-to-end tests of web applications in Jenkins pipelines.

Apache License 2.0

7 stars 6 forks source link

Can we remove this `sed`? #48

Open o-liver opened 10 months ago

o-liver commented 10 months ago

It we have the following, here in the dockerfile:

# Workaround for https://npm.sap.com issue with open SSL in Debian Buster
RUN CIPHERS="$(openssl ciphers)" && sed -i "s/DEFAULT@SECLEVEL=2/$CIPHERS:DH-RSA-AES256-SHA256/g" /etc/ssl/openssl.cnf

Now we do not user npm.sap.com anymore and buster is also about to be removed. Can we remove this sed?

@fwilhe Could you comment? Do you have any memory of this?

o-liver commented 10 months ago

The PR where this comes from with some discussion

fwilhe commented 3 weeks ago

@o-liver Sorry, just saw this now. Sure this can be removed. Just seen you've updated the image to bookworm, and as npm.sap.com is not operational anymore there is no reason to keep this line.