search

SAP / fundamental-ngx

Fundamental Library for Angular is SAP Design System Angular component library
https://sap.github.io/fundamental-ngx
Apache License 2.0
267 stars 127 forks source link

[P2][Sourcing][Accessibility]`fdp-table` Missing tooltip for row selection #10055

Closed CSENoni closed 1 year ago

CSENoni commented 1 year ago

Is this a bug, enhancement, or feature request?

Bug

Briefly describe your proposal.

https://github.com/SAP/fundamental-ngx/assets/22842279/96b73b0e-515b-4ade-ac68-b3f4da943e97

Which versions of Angular and Fundamental Library for Angular are affected? (If this is a feature request, use current version.)

latest or previous

If this is a bug, please provide steps for reproducing it.

Using https://ui5.sap.com//#/entity/sap.ui.table.Table/sample/sap.ui.table.sample.Selection for reference.

Please provide relevant source code if applicable.

Is there anything else we should know?

fkolar commented 1 year ago
  1. This is accessibility problem - yes it should be there. The title needs to be set for these controls.
  2. The second part I am not sure about: Also platform table is missing two selection behavior,. says who?
  3. For the 'another thing', can you point to which F-NGX example does not have blue focus border ?
    • Definitely this would not be a bug, so you should separate this into the new issue. We should try to look at also into spec.
fkolar commented 1 year ago

I can replicate now with the row-selection example. The white border is not definitely not correct. Unfortunately, none of the UI5 demos works today, not even specs is accessible.

This issue is about border color of the selected rows and Tooltip right ? - Nothing else . Can you ping me offline - I am not sure who is CSENoni

fkolar commented 1 year ago

So this issue about a first - missing tooltip for row selection. @CSENoni, once you move things out can you clean up the main description and leave in there only the tooltip ? Then you can you delete all these discussions and keep only description and remove WIP.

droshev commented 1 year ago

WE would need to downport to ng15

CSENoni commented 1 year ago

Tooltip is showing now for single and multiple selection in 0.43.8. Thanks!