SAP / fundamental-ngx

Fundamental Library for Angular is SAP Design System Angular component library
https://sap.github.io/fundamental-ngx
Apache License 2.0
266 stars 126 forks source link

[Sourcing][Accessibility][Multi input Mobile mode dialog]Popup contains unnecessary regions #10299

Closed I543348 closed 1 year ago

I543348 commented 1 year ago

Is this a bug, enhancement, or feature request?

Bug

Briefly describe your proposal.

The popup contains unnecessary regions (e.g.

droshev commented 1 year ago

@I543348 Can you provide more context information and screenshots?

I543348 commented 1 year ago

Hi @droshev ,This is a customer testing issue. We had discussed this and triaged the issue along with ATL. Could you please connect with them for more details?

Thanks.

droshev commented 1 year ago

@I543348 The agreement is that you provide us with all the input so we can work on the issue.

nikolay-kolarov commented 1 year ago

Hi,

I checked the dialog (MultiInput on Mobile -> value help) and there is a footer element, which is a landmark element and forms a region for Jaws https://www.w3.org/WAI/WCAG21/Techniques/aria/ARIA11. In this case the header even is missing otherwise the customer might have complained that there are two regions.

Still, this is an on-purpose decision to have a header and footer in the dialogs in order to have a common consistent structure. And this is used across UI5 and UI5 WebComponents dialogs.

So I think we can close this one.

Best Regards, Nikolay

I543348 commented 1 year ago

ATL Re-verification needed

sagar7259 commented 1 year ago

Hello,

This can be documented as a note and close this issue has this is an on-purpose decision to have a header and footer in the dialogs in order to have a common consistent structure. And this is used across UI5 and UI5 WebComponents dialogs has per the comment from Nikolay.

Regards, Sagar