SAP / fundamental-ngx

Fundamental Library for Angular is SAP Design System Angular component library
https://sap.github.io/fundamental-ngx
Apache License 2.0
267 stars 127 forks source link

[P3.1][Sourcing] `fdp-multi-combobox` fires multiple times after value is selected #10457

Closed CSENoni closed 1 year ago

CSENoni commented 1 year ago

Is this a bug, enhancement, or feature request?

bug

Briefly describe your proposal.

After value is selected/deselected in fdp-multi-combobox, selectionChange emits multiple times:

https://github.com/SAP/fundamental-ngx/assets/22842279/63b95f53-d899-4142-873c-e14fa0458433

As observed from the log:

Expectation is that it should emits only one time.

Which versions of Angular and Fundamental Library for Angular are affected? (If this is a feature request, use current version.)

Angular 15 0.43.8

If this is a bug, please provide steps for reproducing it.

Please provide relevant source code if applicable.

https://stackblitz.com/edit/angular-9jp2kz-7cgxzk?file=src%2Fapp%2Fmulti-combobox-loading-example.component.ts

Is there anything else we should know?

It can be low/medium priority since it is not a blocker but on our application side we have to handle it carefully especially with api call.

CSENoni commented 1 year ago

@droshev @fkolar I think this is no longer WIP since pr is created for this issue.

fkolar commented 1 year ago

@droshev @fkolar I think this is no longer WIP since pr is created for this issue.

yes, you are right