search

SAP / fundamental-ngx

Fundamental Library for Angular is SAP Design System Angular component library
https://sap.github.io/fundamental-ngx
Apache License 2.0
268 stars 130 forks source link

Component Bug: Dynamic Page Sub-Header Style #10550

Closed rebecagm closed 1 month ago

rebecagm commented 1 year ago

Is this a bug, enhancement, or feature request?

Bug

Briefly describe your proposal.

The fd-dynamic-page-subheader style should not present the shadow when (1) there is the fd-tab-list below, and (2): [collapsible]="false" [pinnable]="false" [collapsed]="false"

sub-header-false

That is how it should look, but without the custom css:

custom-sub-header

Which versions of Angular and Fundamental Library for Angular are affected? (If this is a feature request, use current version.)

Current

If this is a bug, please provide steps for reproducing it.

See screenshots above

Please provide relevant source code if applicable.

Is there anything else we should know?

github-actions[bot] commented 1 year ago

Hello @rebecagm, thank you for using fundamental-ngx! The fundamental-ngx team will triage your issue as soon as possible.

pawelkarwat commented 1 month ago

Hi, is there a plan to implement a fix for this issue? We are experiencing the same problem with the shadow being displayed

InnaAtanasova commented 1 month ago

hi @rebecagm and @pawelkarwat , I added a fix for this issue in https://github.com/SAP/fundamental-ngx/pull/12443 It will be soon available in the latest rc version. Let me know if I missed something. Thank you!