Sprint 123 Defect hunting - Horizon Testing

[g-cheishvili]

Issues that are found during the deffect hunt

[g-cheishvili]

Core grid list keyboard navigation is not bound to the grid list container. If you arrive at the last item in any of the grid list containers and click "arrow right" it will jump to the next example component. Additionally, grid list item does not have ability to have navigation vertically. Only arrow right and arrow left work

moved down

[g-cheishvili]

Breadcrumbs RouterLink example has incorrect routes attached to it and as a result user will not be able to see correct navigation when clicked on a example

DONE

[g-cheishvili]

Core illustrated message inline SVG example calls inject outside of the Injection Context

DONE

[g-cheishvili]

~~ Arrow is in a wrong place. Popover placement.~~

moved down

[g-cheishvili]

Micro process flow shows incorrectly labels. They are cut out

DONE

[g-cheishvili]

Does not look compact to me, plus example description mentions removed property compact

EDIT: Looks like Compact for the panel should have very small difference from the cozy

DONE: Fixed text

[g-cheishvili]

When you start resizing popover, it starts selecting everything that is behind

moved down

[g-cheishvili]

Drag and drop does not work on card layout

moved down

[g-cheishvili]

Platform search field's category seems out of the context

moved down

[g-cheishvili]

Smart filter bar docs page

[g-cheishvili]

Platform upload collection

[g-cheishvili]

Platform form generator hint template should not be rendered like this

SOLVED

[mikerodonnell89]

I thought this issue with the error message styling should have been fixed by https://github.com/SAP/fundamental-ngx/pull/10574 but I am still seeing it on the main branch

[mikerodonnell89]

After closing/dismissing a dialog, we should be bringing the focus back to the previously focused element. Now it is going back to the start of the page

moved down

[mikerodonnell89]

When a feed list item has more text than allowed by the maxChars input, there's no way to click the "____ more" text via keyboard. It can be focused but space/enter does not click the link

moved down

[mikerodonnell89]

Inline help tooltips in addition to @g-cheishvili's comment about the positioning not displaying properly, padding/styling is missing - looks similar to the error message styling issue i mentioned above

moved down

[mikerodonnell89]

Popover focusAutoCapture does not focus the first tabbable element immediately after opening

moved down

[droshev]

multi input(core) - adding custom tokens is kinda broken - comes from https://github.com/SAP/fundamental-ngx/pull/10601

the selected is empty

[droshev]

the hamburger menu isn't responding

[droshev]

Tile Title in NGX isn't as bold as in styles: NGX:

Styles:

@N1XUS will fix it with the vertical nav PR

[droshev]

Variant management/Smart Filter Bar spacing isn't 100% matching the visual specification

moved down

[InnaAtanasova]

Multi Combobox Core NOTE FROM MIKE I think this is not a bug, this is how it is working on ui5

To reproduce:

• type "test" in the input field
• the error message will appear correctly
• go to the dropdown menu with the keyboard keys and then back to the input field
• add another letter to "test"
• the error message appears for a sec in a popover

https://github.com/SAP/fundamental-ngx/assets/39598672/3ee58813-50b1-44b0-8753-4b72410746ae

[InnaAtanasova]

Multi Combobox Core in Mobile mode MIKE - fixed broken CSS for the error message

[InnaAtanasova]

Multi Combobox Core in Mobile mode - MIKE #10712 When an item is selected the input is cleared but the item doesn't change its state in the list. The user might get confused that something went wrong. If we remove the this.close() calls from the non-mobile version, we see this issue persists there as well. but it is not noticeable because the popover is closed on enter press https://github.com/SAP/fundamental-ngx/assets/39598672/c720babd-ba86-4d24-9fef-11e6ca21cc2b

[InnaAtanasova]

Multi Combobox Core in Mobile mode #10712 very insignificant and actually not reproducible in real mobile mode (size) but in desktop you can see it. The list width is not 100% of the container.

[InnaAtanasova]

Multi-Combobox with Groups using the keyboard to open the dropdown shows an error that disappears NOTE FROM MIKE i do think this is intended behavior, assuming you are attempting to add a space character to the input, and no results start with a space

https://github.com/SAP/fundamental-ngx/assets/39598672/9d6bf481-cfc9-49cc-8f05-ccc493a4bb0f

EDIT: actually same behaviour is observed with the other examples. Is this a desired effect?

https://github.com/SAP/fundamental-ngx/assets/39598672/63f5b5ae-7b89-43c0-bad4-b41a2b9a75fb

[InnaAtanasova]

Multi Input Core - #10712 NOTE FROM MIKE I believe the "____ more" text is only for compact tokenizer, not cozy In smaller screens the input should have an indication how many more items are selected but not shown. For example 5 more. In this case there's no way for the user to know how many items are selected until they open the dropdown list

FROM INNA disagree. This is a regression. We had a diferent behaviour before. You can see it here: https://sap.github.io/fundamental-ngx/#/core/multi-input

UI5 implementation:

[droshev]

Clustering the findings:

Blockers:

• [x] Theming (to be confirmed)- https://github.com/SAP/fundamental-ngx/issues/10700
• [x] Theming (to be confirmed)- https://github.com/SAP/fundamental-ngx/issues/10628
• [x] Theming (Icons) (to be confirmed)- https://github.com/SAP/fundamental-ngx/issues/10603
• [x] Arrow is in a wrong place. Popover placement and styling removes padding in
• [x] When you start resizing popover, it starts selecting everything that is behind
• [x] Platform search field's category seems out of the context/ Buttons on hover jump left/right

Issues:

• [ ] Popover (to be confirmed) - https://github.com/SAP/fundamental-ngx/issues/10602

• [ ] Dynamic Page (to be confirmed) - https://github.com/SAP/fundamental-ngx/issues/10550

• [ ] Busy Indicator (to be confirmed) - https://github.com/SAP/fundamental-ngx/issues/10547

• [ ] Wizard (to be confirmed) - https://github.com/SAP/fundamental-ngx/issues/10391

• [x] Core Multi Input - on clicking the link more, we should see listed only the selected items, not all of them. In platform is correct. - #10787

• [ ] Core mobile calendar: unnecessary scrollbar:

• [x] Carousel: keyboard navigation works only once. After slide being changed, user needs to click on the image again in order for the navigation to work again - https://github.com/SAP/fundamental-ngx/pull/10767

• [x] Carousel loading example: Busy indicator a bit off - https://github.com/SAP/fundamental-ngx/pull/10767

• [x] Carousel vertical variant does not react to Arrow down and up keys, only to arrow left and right - https://github.com/SAP/fundamental-ngx/pull/10767

• [ ] Dialog Resizable -

• [x] Link: when focused, icon color is still blue: Will be fixed with https://github.com/SAP/fundamental-styles/pull/4913

• [x] More as an improvement: Core combobox accepts TemplateRef input property for the item renderer. It's better to use structural directive here with support of typed arguments - N1XUS https://github.com/SAP/fundamental-ngx/pull/10785

• [ ] Pagination: when page loading is in progress, I think we should disable pagination buttons in order not to mess up the data.

• [x] Docs sidebar has standard scrollbar. Should be fundamentals one: - #10787

• [x] Rating indicator docs uses native controls (inputs, selects). Should be replaced with fundamentals alternative - N1XUS

• [x] Core select: Icon in placeholder is skewed:

• [ ] Time: using mousewheel is not smooth (not feeling natural). I'm assuming it does not count delta property of mousewheel efect and just moves the value up/down based on the direction of the scroll. I would suggest applying similar logic as we have with dragging - we scroll the numbers according to the deltaX of the mousewheel event;

• [ ] Core grid list keyboard navigation is not bound to the grid list container. If you arrive at the last item in any of the grid list containers and click "arrow right" it will jump to the next example component. Additionally, grid list item does not have ability to have navigation vertically. Only arrow right and arrow left work

• [x] Drag and drop does not work on card layout

• [ ] After closing/dismissing a dialog, we should be bringing the focus back to the previously focused element. Now it is going back to the start of the page

• [ ] Popover focusAutoCapture does not focus the first tabbable element immediately after opening

• [ ] Variant management/Smart Filter Bar spacing isn't 100% matching the visual specification

[mikerodonnell89]

core multi-combobox - when opening in mobile mode on chrome on an actual phone, URL bar blocks the input and you can't swipe/scroll to see it.

[g-cheishvili]

Something's terribly wrong with platform thumbnail and I do not know whether we should delete it or fix it => deprecated component. To be removed soon

[N1XUS]

@droshev Drag and drop does not work on card layout it's actually working, but the drag area of the card is not obvious. Need to discuss the design and user interaction logic

[N1XUS]

After closing/dismissing a dialog, we should be bringing the focus back to the previously focused element. Now it is going back to the start of the page - checked with Dialog documentation page. Everything works as described. Could someone provide a page where this is happening?

[N1XUS]

Core mobile calendar: unnecessary scrollbar: -> is not a bug. We use size constrains in config of the dialog window:

[N1XUS]

Inline help does not look vertically centered

[droshev]

@kalo2711 Can you retest the not checked issues and document what is reproducible?

[kalo2711]

NOT fixed:

• Pagination: when page loading is in progress, I think we should disable pagination buttons in order not to mess up the data.
• Core mobile calendar: unnecessary scrollbar: (Landscape only)
• Dialog Resizable
• Time: using mousewheel is not smooth (not feeling natural) This seems good to me (buttons), the scrolling is just too accelerated.
• Core grid list keyboard navigation is not bound to the grid list container
• After closing/dismissing a dialog, we should be bringing the focus back to the previously focused element. This works when closing dialogs and doesn't reproduce the issue, but the dismissing dialog isn't compiling.
• Popover focusAutoCapture does not focus the first tabbable element immediately after opening
• Variant management/Smart Filter Bar spacing isn't 100% matching the visual specification