SAP / fundamental-ngx

Fundamental Library for Angular is SAP Design System Angular component library
https://sap.github.io/fundamental-ngx
Apache License 2.0
263 stars 126 forks source link

[Sourcing-2][Accessibility: ACC-264.1][WIP] Within settings dialog , User redirected to dialog not conveyed. #11249

Open JyotiKumari1507 opened 7 months ago

JyotiKumari1507 commented 7 months ago

Is this a bug, enhancement, or feature request?

Bug

Describe your proposal.

https://sap.github.io/fundamental-ngx/#/platform/settings-generator. Within NGX platform settings , When the user activates 'Settings' UI and the user is redirected to a dialog, the same info must be conveyed by screen reader.

Can you handle that on the application side

No

Which versions of Angular and Fundamental Library for Angular are affected? Please, specify the exact version. (If this is a feature request, use current version.)

All latest version

If this is a bug, please provide steps for reproducing it; the exact components you are using;

Using Screen reader easily can check NGX platform settings, by clicking setting dialog open for settings but same isn't conveyed by screen reader’.

Please provide relevant source code (if applicable).

Please provide stackblitz example(s).

In case this is Accessibility related topic, did you consult with an accessibility expert? If not, please do so and share their recommendations.

Yes we have got this bug from Accessibility expert only.

Did you check the documentation and the API?

Yes

Did you search for similar issues?

Is there anything else we should know?

nikolay-kolarov commented 7 months ago

Hi @JyotiKumari1507,

Could you please provide more info where you observed this? I tested the last sample: image And the dialog was correctly announced.

Thanks, Nikolay

JyotiKumari1507 commented 7 months ago

@nikolay-kolarov @droshev When the user activates the 'settings' UI, the user is redirected to a dialog, but the same info is not conveyed to the user by screen reader. please refer attached screenshot

image
nikolay-kolarov commented 7 months ago

Hi @droshev, Hi @JyotiKumari1507,

As said, I tested the dialog on the provided test page and there the dialog role is announced. So then the respective app can be checked if they use the same UI version, and the same component, and why it is not announced there.

Best Regards, Nikolay

JyotiKumari1507 commented 7 months ago

@droshev @nikolay-kolarov This issue may fix with NGX upgrade. If you want mean while i can get recording from accessibility team also.

droshev commented 6 months ago

Most of the fields are not filled.

JyotiKumari1507 commented 6 months ago

@droshev please let us know what fields are pending to fill from our side

droshev commented 3 months ago

@JyotiKumari1507 can you create either stackblitz or share the steps how to reproduce the issue and what the expected behavior is?

droshev commented 3 months ago

@JyotiKumari1507 Can you create a stackblitz example, steps to reproduce and what the expectation is? Otherwise we will close the ticket.

divyamalhotra488 commented 1 month ago

Hi @droshev, you can try with the example here

Click on user avatar-> Go to Settings -> Dialog popup is not conveyed in screen reader.

droshev commented 1 month ago

@divyamalhotra488 why can't you add whatever you need to the dialog template?

divyamalhotra488 commented 1 month ago

Hi @droshev, UI wise it looks okay. The issue is that the dialog being opened is not conveyed by the screen reader. This is violating accessibility standard.

droshev commented 1 month ago

@divyamalhotra488 you have the control of the dialog, so you can set anything needed.

divyamalhotra488 commented 1 month ago

@droshev, could you please suggest what attribute to set for screen reader to recognise dialog being opened ?