SAP / fundamental-ngx

Fundamental Library for Angular is SAP Design System Angular component library
https://sap.github.io/fundamental-ngx
Apache License 2.0
268 stars 129 forks source link

[Sourcing-2][Accessibility: ACC-264.1]Region: accessible name not provided in FD-DYNAMIC-PAGE #11252

Closed JyotiKumari1507 closed 3 weeks ago

JyotiKumari1507 commented 9 months ago

Is this a bug, enhancement, or feature request?

Bug

Describe your proposal.

Component having issue: https://sap.github.io/fundamental-ngx/#/core/dynamic-page

When there is ambiguity about an ARIA region, landmark or HTML section, developers must ensure that these elements contain meaningful accessible labels to assist users of screen readers to identify and distinguish the section, region or landmark. Common methods of providing accessible labels are the aria-labelledby attribute (best used when a visual label already exists in the page) and the aria-label attribute (when no visual label exists).

Common ARIA landmark roles include:

role=application role=banner role=complementary role=contentinfo role=form role=main role=navigation role=search Common HTML5 section elements include:

article aside nav section

This FD-DYNAMIC-PAGE (role=region) does not have a mechanism that allows an accessible name value to be calculated. Code Snippet:
Shared Keys
64bb57a9-6962-466d-a069-eed8c7fbcc54
<div class="fd-tabs-custom is-cozy.

Can you handle that on the application side

No

Which versions of Angular and Fundamental Library for Angular are affected? Please, specify the exact version. (If this is a feature request, use current version.)

All latest version

If this is a bug, please provide steps for reproducing it; the exact components you are using;

Using Access assistant easily can check.

  1. Login with the URL Provided.
  2. Activate 'shared keys' app. • Download Access assistant tool from level access. • For registered AMP user, login with your SAP email ID into SAP AMP instance: sap.levelaccess.net

Please provide relevant source code (if applicable).

Please provide stackblitz example(s).

In case this is Accessibility related topic, did you consult with an accessibility expert? If not, please do so and share their recommendations.

Yes we have got this bug from Accessibility expert only.

Did you check the documentation and the API?

Yes

Did you search for similar issues?

Is there anything else we should know?

nikolay-kolarov commented 9 months ago

Hi @droshev,

I am not sure where I can reproduce this. Do you have a landmark API in the dynamic page? If not, you might need to invest into it and provide the possibility to the apps to define the landmarks and their labels. Here is more info from the acc guide in UI5: https://ui5.sap.com/test-resources/sap/m/demokit/accessibilityGuide/webapp/index.html#/overview/applicationDeveloper/landmark

Best Regards, Nikolay

droshev commented 8 months ago

Image

the attributes role and aria-label should be on the same html element

mikerodonnell89 commented 3 weeks ago

We provide inputs for aria-label and aria-roledescription for the article element which are read by the screenreader. Closing this issue, please open a new one with more specific details if the problem persists.