search

SAP / fundamental-ngx

Fundamental Library for Angular is SAP Design System Angular component library
https://sap.github.io/fundamental-ngx
Apache License 2.0
256 stars 125 forks source link

[BUG] The skeleton view in the table does not work with responsive features #11799

Open pawelkarwat opened 3 weeks ago

pawelkarwat commented 3 weeks ago

Skeleton loading does not work properly alongside page responsiveness features in the Table fundamental-ngx/platform component. If we use [fdpTableCellResponsive] and hide columns or utilize popping columns, skeleton loading does not appear as expected.

Steps to reproduce:

  1. Utilize the Table component in the platform.
  2. Implement hiding columns or popping columns using [fdpTableCellResponsive].
  3. Adjust the screen width to hide a column.
  4. Refresh the page to initiate data loading and observe the skeleton loading behavior.

Expected behavior: During both loading and display states, the skeleton loading should display the same number of columns in the table as after loading the data.

droshev commented 3 weeks ago

@pawelkarwat 

During both loading and display states, the skeleton loading should display the same number of columns in the table as after loading the data.

according to who?

What have provided the basic placeholder, but you are not forced to stay with it and you can customize or use a different one. The idea behind the placeholder is to keep it as simple and basic as possible while the data is being transferred.

pawelkarwat commented 3 weeks ago

2024-04-19_15-18-13 Displaying it this way doesn't look very good, so I suggest sticking to the same number of columns in the skeleton.