SAP / fundamental-ngx

Fundamental Library for Angular is SAP Design System Angular component library
https://sap.github.io/fundamental-ngx
Apache License 2.0
256 stars 125 forks source link

[P2][Sourcing][Accessibility][Value help dialog]: To reach table inside value-help dialog we need to press 3-4 times TAB key #11810

Closed I543348 closed 6 days ago

I543348 commented 2 weeks ago

Is this a bug, enhancement, or feature request?

Bug

Describe your proposal.

Extra 3-4 tabstops to reach table inside value help dialog from "Go" button user needs to press 3 or 4 times TAB Key and then focus starts coming on table. Deviates SAP accessibility guideline https://wiki.one.int.sap/wiki/display/Acc/ACC-264+Details#ACC264Details-acc2641

Expectation: User should press only once TAB key and focus should start moving to table next works fine in ui5 value help dialog : https://sapui5.hana.ondemand.com/#/entity/sap.ui.comp.valuehelpdialog.ValueHelpDialog/sample/sap.ui.comp.sample.valuehelpdialog.recommended

Can you handle that on the application side

No

Which versions of Angular and Fundamental Library for Angular are affected? Please, specify the exact version. (If this is a feature request, use current version.)

Angular: 15 core / platform: 0.43.33

If this is a bug, please provide steps for reproducing it; the exact components you are using;

1) Open dialog 2) start pressing tab until Go button 3) press 3-4 times tab 4) now checkbox on table header shows blue color focus

Ideally only one tab press should work https://deploy-preview-11651--fundamental-ngx.netlify.app/#/platform/value-help-dialog replicable here

Please provide relevant source code (if applicable).

Please provide stackblitz example(s).

https://deploy-preview-11651--fundamental-ngx.netlify.app/#/platform/value-help-dialog the zip file contains both UI5 and NGX value help dialog comparison

Archive.zip

In case this is Accessibility related topic, did you consult with an accessibility expert? If not, please do so and share their recommendations.

Reported by Accessibility test lab team

Did you check the documentation and the API?

Did you search for similar issues?

Is there anything else we should know?

IMPORTANT: Please refrain from providing links or screenshots of SAP's internal information, as this project is open-source, and its contents are accessible to anyone.

mikerodonnell89 commented 2 weeks ago

I think this is coming from the <div fd-scrollbar> container which wraps the search input, show filters, go button, and the whole table. A scrollbar that we may need, depending on screen height