search

SAP / fundamental-ngx

Fundamental Library for Angular is SAP Design System Angular component library
https://sap.github.io/fundamental-ngx
Apache License 2.0
269 stars 129 forks source link

Color Picker with Default Set Of Colors and Custom Colors #11914

Open desaroxx opened 6 months ago

desaroxx commented 6 months ago

Is this a bug, enhancement, or feature request?

feature request

Describe your proposal.

Color Picker with default set of colors with both "Default Color" and "More Colors..." buttons (aka custom colors)

The color picker is already available as a UI5 component: https://sapui5.netweaver.ondemand.com/sdk/#/entity/sap.m.ColorPalette/sample/sap.m.sample.ColorPalettePopover


Screenshot 2024-05-13 at 09 38 53 Screenshot 2024-05-13 at 09 39 02

Can you handle that on the application side

Which versions of Angular and Fundamental Library for Angular are affected? Please, specify the exact version. (If this is a feature request, use current version.)

If this is a bug, please provide steps for reproducing it; the exact components you are using;

Please provide relevant source code (if applicable).

Please provide stackblitz example(s).

In case this is Accessibility related topic, did you consult with an accessibility expert? If not, please do so and share their recommendations.

Did you check the documentation and the API?

Did you search for similar issues?

Is there anything else we should know?

IMPORTANT: Please refrain from providing links or screenshots of SAP's internal information, as this project is open-source, and its contents are accessible to anyone.

desaroxx commented 6 months ago

please release this feature down to V0.40.

droshev commented 6 months ago

Thanks for the suggestion. While I understand its value, adding a new component right now would stretch our resources thin. Even we could implement the component, we won't have any capacity to downport it all the way to version 0.40. In the meantime, have you considered using ui5 webcomponents color picker?

desaroxx commented 6 months ago

thank you for your answer @droshev. This component is not on top of our priorities right now, but we would appreciate if we could put this on the roadmap midterm. For keeping our solution as simple as possible I'd like to avoid dealing with a further UI framework and focus on fundamental ngx.

zaheral commented 1 month ago

Hi @droshev , do we have some plans that this component will be offered by Fundamental? Because we got more use cases on our side and it became more urgent to have it. Using UI5 web-component brings complexity with it and is harder to maintain. We would prefer to stick with Fundamentals.

droshev commented 1 month ago

@zaheral the strategy for new components is to create ui5 webcomponents and then create angular wrappers instead of creating native angular components => can you explore using ui5 webC NGX color picker