search

SAP / fundamental-ngx

Fundamental Library for Angular is SAP Design System Angular component library
https://sap.github.io/fundamental-ngx
Apache License 2.0
268 stars 129 forks source link

[FEATURE REQUEST] Add modal property to Popover control #12210

Closed egorwow70 closed 1 month ago

egorwow70 commented 3 months ago

Is this a bug, enhancement, or feature request?

It is a feature request.

Describe your proposal.

Is it possible to add a "modal" property to the Popover control like it is working in sapui5? https://sapui5.hana.ondemand.com/#/api/sap.m.Popover%23constructor

image

Can you handle that on the application side

No

Which versions of Angular and Fundamental Library for Angular are affected? Please, specify the exact version. (If this is a feature request, use current version.)

Did you check the documentation and the API?

Yes, I didn't find it here - https://sap.github.io/fundamental-ngx/#/core/popover/api

droshev commented 3 months ago

@egorwow70 we have an input for that closeOnOutsideClick

alexhristov14 commented 2 months ago

@egorwow70 In the api tab, if you select the PopoverComponent file, you will find the closeOnOutsideClick input which is essentially the same as the modal property as commented above.

egorwow70 commented 2 months ago

@alexhristov14

Hello, sorry for the late response, I think they are different, because closeOnOutsideClick controls whether the control can be closed by outside click. But modal property in sapui5 makes the outside background black and you cannot close it by clicking outside anymore.

image